Merged
Conversation
Makring tests that have no assertions with the annotation to suppress phpunits warning around risky tests closes 1370
Contributor
Author
|
To be honest I don't think a lot of these tests bring value, for the most part, they just test the constructor works can get a new instance. |
Member
|
It seemed like a good idea at the time of writing (6-8 years ago). Now, I agree with you that such tests bring no value. If you want you can remove them.
|
Contributor
Author
|
I’ll work on updating this to remove tests that have little to no value. As for the CS and static analysis I’ll raise another PR to fix this. |
Removing all tests that creates a new instance but doesn't call any methods nor preform any assertions.
Contributor
Author
|
Fixed CS issues in #1372 |
Contributor
Author
Member
|
I don't really want to keep master red, but considering you plan to address all issues eventually as separate MRs I am fine with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making tests that have no assertions with the annotation to suppress phpunits warning around risky tests
closes #1370